So, you guys can see this, right? Yeah. Okay. All right, so I'm concerned that we're grabbing— I'm concerned that we're grabbing predict. Like, I'm concerned that we're grabbing from the parent model, from the model config. For, you know, for what essentially amounts to something that I think is— that would change, right? Basically.
So what happens with your patch, Hashim, is, um, if we— where was that? The multi-output, right? So your changes sort of make it apparent that this— that the scores and the models are too intertwined right now. Right? Because you now begin to inspect the model can predict to see if it's features or if it's a singular feature. And now all this extra code just explodes.
So basically, the code in each scorer is too tied into the models is what I'm saying. Right. I believe, right? Because right now you, you— we, we, this, this, the change that you made resulted in a big change, not a big change, but like it resulted in quite a few lines added in the score, right? And it showed that the functionality of the models is now too deeply tied to the functionality of the scores or the scores of functionality of the scores is the implementation of the scores is too deeply tied to the implementation of the model. Since we're introspecting the predict config of the model.
So what I'm suggesting is that we do something like this, essentially, right? Where we just make this self.parent. And so now the only dependency on the model becomes the prediction. And so we can ask, you know, we had the scorer do, um, let's see, like, this is where it's like, okay, well, maybe we need to say label equals, uh, model.predict. And yeah, so I don't know, predict or feature, we should probably just say feature.
So I don't know, this is where it's like, that's not— now I'm not sure what terminology to use here, but you see how now we end up with— so now it's like the functionality isn't so tied together, right? So if you had— so now if you end up with a multi-output model, you could verify, right? Like feature only works like— let's see.
So we're also gonna— there's also gonna be some— we need to do some more input verification on the config dictionaries and stuff, but we can— so safe— let's safely assume that, you know, if we say feature then and somebody provides features, right, a list, then it would kick them out and not let them instantiate that classification accuracy. Right? So they would have to use a multi-output-specific classification accuracy score, right?
And that, you know, that minimizes the amount of, you know, the possibilities for issues with this scorer here, right? Because it's no longer tied into every single model and having to deal with, oh, well, what if this model does this, right? Well, it doesn't matter because we're just calling predict and then we're looking at the feature data.
Does that— do you guys see what I'm saying? Is this making any sense?